Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Исправить stack level для предупреждений #228

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

leshchenko1979
Copy link
Owner

No description provided.

@leshchenko1979 leshchenko1979 self-assigned this Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (267215d) to head (e29d103).

❗ Current head e29d103 differs from pull request most recent head 12f0cb3. Consider uploading reports for the commit 12f0cb3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   88.98%   89.55%   +0.56%     
==========================================
  Files          11       11              
  Lines         563      584      +21     
==========================================
+ Hits          501      523      +22     
+ Misses         62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leshchenko1979 - I've reviewed your changes and they look great!

General suggestions:

  • Consider optimizing the stack inspection process for performance, as it can be expensive.
  • Review the handling of module filenames to avoid potential redundancy and ensure edge cases are covered.
  • Ensure robust error handling when accessing and traversing the call stack.
  • Expand testing to cover more edge cases and real-world scenarios for the new utility function.
  • Evaluate the complexity of the new utility function and consider simplifying it if possible to maintain code maintainability.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟡 Complexity: 1 issue found
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

fast_bitrix24/utils.py Outdated Show resolved Hide resolved
fast_bitrix24/utils.py Outdated Show resolved Hide resolved
fast_bitrix24/utils.py Show resolved Hide resolved
tests/test_warnings.py Show resolved Hide resolved
tests/test_warnings.py Show resolved Hide resolved
fast_bitrix24/utils.py Show resolved Hide resolved
fast_bitrix24/utils.py Show resolved Hide resolved
@leshchenko1979 leshchenko1979 merged commit 414bb97 into master Mar 23, 2024
9 checks passed
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue227 branch March 23, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant