-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Исправить stack level для предупреждений #228
Conversation
…к, чтобы показывать на пользовательский код Fixes #227
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 88.98% 89.55% +0.56%
==========================================
Files 11 11
Lines 563 584 +21
==========================================
+ Hits 501 523 +22
+ Misses 62 61 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @leshchenko1979 - I've reviewed your changes and they look great!
General suggestions:
- Consider optimizing the stack inspection process for performance, as it can be expensive.
- Review the handling of module filenames to avoid potential redundancy and ensure edge cases are covered.
- Ensure robust error handling when accessing and traversing the call stack.
- Expand testing to cover more edge cases and real-world scenarios for the new utility function.
- Evaluate the complexity of the new utility function and consider simplifying it if possible to maintain code maintainability.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
No description provided.