Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Создавать копию объекта params в UserRequestAbstract #244

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Создавать копию объекта params в UserRequestAbstract #244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7aba7
Создавать копию объекта params в UserRequestAbstract
leshchenko1979 Jul 23, 2024
fde51d0
Fix if params is None
leshchenko1979 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fast_bitrix24/user_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def __init__(

# st_params будет использоваться для проверки параметров,
# но на сервер должны уходить параметры без изменения регистра
self.params = params
self.params = params.copy()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Consider handling the case where params is None.

If params can be None, calling params.copy() will raise an AttributeError. It might be safer to add a check or default to an empty dictionary.

self.st_params = self.standardized_params(params)

self.mute = mute
Expand Down
Loading