Skip to content

Commit

Permalink
Update datetime import for consistency in test_class_method_with_params
Browse files Browse the repository at this point in the history
- Changed the datetime import to include timezone for improved clarity.
- Updated the usage of datetime.now to utilize timezone.utc for better consistency in handling time zones.

These changes enhance the accuracy of time-related tests in the test suite.
  • Loading branch information
leshchenko1979 committed Dec 19, 2024
1 parent c2c1c33 commit b496768
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 2 deletions.
31 changes: 31 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Changelog

## [1.1.0] - 2024-03-18

### Added
- Instance-specific caching for both sync and async class methods
- Smart detection of instance methods vs standalone functions
- Improved logging for cache operations and method detection
- Better handling of ignored parameters in instance methods

### Fixed
- Fixed cache key generation for instance methods to ensure proper instance separation
- Fixed infinite recursion issues in instance method detection
- Fixed handling of ignored parameters in instance methods
- Fixed cache invalidation for instance methods when code changes

### Changed
- Improved instance method detection to exclude built-in types
- Updated documentation with instance method caching examples
- Simplified cache key generation logic
- Enhanced debug logging for better troubleshooting

### Developer Notes
- Added comprehensive test coverage for instance method caching
- Added test cases for both sync and async instance methods
- Added tests for multiple instances of the same class
- Added tests for ignored parameters in instance methods

## [1.0.0] - Previous version

Initial release with basic caching functionality.
4 changes: 2 additions & 2 deletions tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def get_data(): ...


def test_class_method_with_params(cache):
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from pathlib import Path
from perscache import Cache
from perscache.storage import LocalFileStorage
Expand All @@ -114,7 +114,7 @@ def cache_method(self, what: str, when: datetime):
return f"What: {what}, Timestamp: {when.isoformat()}"

pt = PerscacheTest()
pt.cache_method("This thing happened", datetime.now(tz=datetime.UTC))
pt.cache_method("This thing happened", datetime.now(tz=timezone.utc))


def test_sync_class_method(cache):
Expand Down

0 comments on commit b496768

Please sign in to comment.