Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments with doubleslash are not stripped before compile #4264

Open
matthew-dean opened this issue Mar 6, 2024 Discussed in #4262 · 1 comment
Open

Comments with doubleslash are not stripped before compile #4264

matthew-dean opened this issue Mar 6, 2024 Discussed in #4262 · 1 comment
Labels

Comments

@matthew-dean
Copy link
Member

Discussed in #4262

Originally posted by mperry2 February 29, 2024
I've got a variable that's a list of several hundred items. I'd like to add comments between blocks of the items like I would in a regular programming language. I read at #202 (comment) that // comment will be removed, so I used those. However, the comments are not being stripped out before processing and are becoming part of the list.

I'm wondering if something's wrong with my syntax and I'm just not seeing it.

Here's a contrived test case. Link to Less-To-CSS Playground

less source:

@items:
// Fruit
    apple,
    banana,
    cherry,

// Vegetables
    carrot,
    potato,
;

each(@items, {
  div#@{value} {
    color: blue;
  }
})

Output:

div#apple {
  color: blue;
}
div#banana {
  color: blue;
}
div#cherry {
  color: blue;
}
div#// Vegetables carrot {
  color: blue;
}
div#potato {
  color: blue;
}

Notice that line 10 has div#// Vegetables carrot as the selector when it should be div#carrot.

Any idea on how to fix this? I don't want to use multiple lists.

@puckowski
Copy link
Contributor

I have a fix for this issue. I will submit a PR to resolve sometime later today (11/27/24).

puckowski added a commit to puckowski/less.js that referenced this issue Nov 28, 2024
* Fix for issue less#4264. Strip line comments from expressions to avoid
  invalid CSS output.
puckowski added a commit to puckowski/less.js that referenced this issue Dec 8, 2024
* Fix for issue less#4264. Strip line comments from expressions to avoid
  invalid CSS output.
puckowski added a commit to puckowski/less.js that referenced this issue Dec 8, 2024
* Fix for issue less#4264. Strip line comments from expressions to avoid
  invalid CSS output.
puckowski added a commit that referenced this issue Dec 8, 2024
* Fix for issue #4264. Strip line comments from expressions to avoid
  invalid CSS output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants