Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue:3737) allow blank variable declarations #4294

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

puckowski
Copy link
Contributor

What:

Fixes issue #3737 where blank CSS variable declarations resulted in parsing errors.

Why:

Blank CSS variables are valid.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Existing tests are passing locally.

The following Less.js:

*, ::before, ::after {
  --tw-pan-x:  ;
  --tw-pan-y:  ;
  --tw-pinch-zoom:  ;
  --tw-scroll-snap-strictness: proximity;
}

becomes:

*,
::before,
::after {
  --tw-pan-x: ;
  --tw-pan-y: ;
  --tw-pinch-zoom: ;
  --tw-scroll-snap-strictness: proximity;
}

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 29, 2024
@puckowski
Copy link
Contributor Author

I submitted a few PRs. I expect rebase(s) will be needed in order to merge all of them, so let me know when a rebase is needed.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 7, 2024
@matthew-dean
Copy link
Member

@puckowski Looks like we have a merge conflict now

* Fixes issue with blank CSS variable declarations.
@puckowski
Copy link
Contributor Author

Tests passing locally. CI looks flaky.

@puckowski
Copy link
Contributor Author

Rebased after merge conflict. Changes approved by one reviewer. Squashing and merging to avoid future merge conflicts.

@puckowski puckowski merged commit 509a007 into less:master Dec 8, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants