-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tint and shade functions, fixes #944 #947
Conversation
Maybe the I also don't think the default amount of |
Not sure what @ricardobeat means by inverting the amount value? (or the example without colours?) I agree that a default of 10% is a bit OTT, I'd prefer people have to be explicit about how much shading they are adding.. the only defaults are where the value can be absolute |
Alter direction of shade amount
…s altered by the color it's mixing with
Initially I agreed about the sign of the amount, but then I realised that the direction of the change is determined by the color it's blending with - tint goes towards white, shade towards black - so it doesn't need negating. |
good but don't check-in the less-1.3.0.js file... could you revert that file and rebase it into 1 commit? I can do this if your not sure how. |
Direction of shade should be same as for tint because its direction is altered by the color it's mixing with
Sigh. I thought this would be a good learning opportunity, but I think I completely screwed that up... I did (after about 20 failed attempts):
This all made some kind of sense until the final merge (why a merge? this should be replacing?), and I've ended up with a whole new bunch of commits that seem to have ignored the squashing and reverting of that js file. What did I do wrong? |
no idea, thats what I would do. |
Gave up on git. I trashed that entire fork and made my changes again in a clean fork/branch/pull and now it all looks happy. See #953 |
No description provided.