Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] JSON::RPC::Legacy::Client: Do not try to parse non-existing JSON #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregoa
Copy link

@gregoa gregoa commented Sep 25, 2024

In Debian we are currently applying the following patch to JSON-RPC.
We thought you might be interested in it too.

From fc84cb2df7ef9cbc33f6fc03975b3a96f34bb9ff Mon Sep 17 00:00:00 2001
From: Guillem Jover <[email protected]>
Date: Sun, 21 Jul 2024 23:27:16 +0200
Subject: [PATCH] JSON::RPC::Legacy::Client: Do not try to parse non-existing
 JSON

If the server reported a server error, then we get no JSON. We should
return immediately instead of trying to parse the non-existing JSON,
otherwise the callers will get confusing and truncated errors.

The patch is tracked in our Git repository at
https://salsa.debian.org/perl-team/modules/packages/libjson-rpc-perl/raw/master/debian/patches/0001-JSON-RPC-Legacy-Client-Do-not-try-to-parse-non-exist.patch

Thanks for considering,
gregor herrmann,
Debian Perl Group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant