Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not flicker #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: should not flicker #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/src/rendering/local_hero_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'package:flutter/animation.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/scheduler.dart';
import 'package:local_hero/src/rendering/controller.dart';
import 'package:local_hero/src/rendering/layer.dart';

Expand Down Expand Up @@ -144,6 +145,16 @@ class RenderLocalHeroFollowerLayer extends RenderProxyBox {
: constraints.enforce(BoxConstraints.tight(requestedSize));
child!.layout(childConstraints, parentUsesSize: true);
size = constraints.constrain(child!.size);

if (requestedSize == null) {
// The size is not known yet, let's wait for the next frame.
// This happens e.g. when the widget is animated (e.g. flutter_animate).
// Removing this "workaround" will result in a flickering effect where the
// first frame of the animation takes the full size of the LocalHeroScope.
SchedulerBinding.instance.addPostFrameCallback((_) {
markNeedsLayout();
});
}
}

@override
Expand Down