ESlint 9 #231
Merged
ESlint 9 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaap3
force-pushed
the
eslint-9
branch
4 times, most recently
from
a3e88a7 to
ce76d7a
Compare
jaap3
force-pushed
the
eslint-9
branch
9 times, most recently
from
26823eb to
3505f2a
Compare
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
reviewed
Dec 17, 2024
| ### Nuxt 3 | ||
|
|
||
| Nuxt has its own ESLint module that configures ESLint based on the Nuxt project configuration. This generates a config | ||
| file that knows about the Nuxt project structure, layers, auto-imports, etc. |
There was a problem hiding this comment.
maybe mention the name / location of that config file here, so you more easily recognize it
There was a problem hiding this comment.
I linked the docs (one line below), it don't think we need to repeat any of that in here.
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
reviewed
Dec 17, 2024
dbunskoek
approved these changes
Dec 17, 2024
I believe I now consistently call it ESLint in the README. |
|
Keeping this open until I'm completely done with the AT follow up, to make sure I don't need to follow up with a fixup PR/release. |
jaap3
force-pushed
the
eslint-9
branch
3 times, most recently
from
7ea72f4 to
cdf0f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert nuxt2 configConvert nuxt3 configDropped Nuxt 2 support (not possible anymore, use the vue2 config for that if necessary).
Nuxt 3 has a module that configures eslint based on the project settings, which is more powerful than we can do with this package. Added instructions on how to integrate our overrides with the nuxt generated config.
Tested everything in the AT frontend monorepo, which has plain javascript, vue2, typescript and vue 3/nuxt subprojects.