Merge pull request #10 from leukeleu/admin-url-false-positive

Fix W007 false positives for catch all routes
leukeleu · Sep 29, 2022 · 956fbc2 · 956fbc2
2 parents 20560ec + b902479
commit 956fbc2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/leukeleu_django_checks/checks.py b/leukeleu_django_checks/checks.py
@@ -138,11 +138,12 @@ def check_admin_url(app_configs, **kwargs):
     """
     for path in ["/admin", "/admin/"]:
         try:
-            resolve(path)
+            match = resolve(path)
         except Resolver404:
             continue
         else:
-            return [W007]
+            if match.route.strip("/") == "admin":
+                return [W007]
     else:
         return []
 

diff --git a/tests/urls/urls.py b/tests/urls/urls.py
@@ -1,7 +1,8 @@
 from django.http import HttpResponse
-from django.urls import path
+from django.urls import path, re_path
 
 urlpatterns = [
     # pragma: no cover
-    path("not-admin/", lambda request: HttpResponse("Hello regular user!"))
+    path("not-admin/", lambda request: HttpResponse("Hello regular user!")),
+    re_path(r"(?P<name>\w+)/", lambda request, name: HttpResponse(f"Hello {name}!")),
 ]