Fix template loading #145
Closed
Fix template loading #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this way 'front-page.twig' can be used so the correct template hierarchy can be followed.
Don't incorpate own custom logic because the third $templates parameter contains correct template name to search for according to the Theme Hierarchy. This method, using the $templates array, also considers the egde-case / bug that @NielsdeBlaauw encoutered: Load the correct archive.twig template when you visit the archive page but there are not Posts in that archive. This because WordPress alraedy take this in account and we now really follow the WordPress flow by using $templates array. Based on #99 of @christiaanstijnen and @Willemijnr. Thank you!
menno-ll
requested changes
May 3, 2019
| if ( 'page' === $type && ! isset( $templates[ "{$type}" ] ) && isset( $templates['singular'] ) ) { | ||
| return $templates['singular']; | ||
| if ( 'page' === $type && ! isset( $twig_templates['page'] ) && isset( $twig_templates['singular'] ) ) { | ||
| $type = 'singular'; |
There was a problem hiding this comment.
Please remove this major exception.
The purpose of this commit is to let clarkson-core work more closely to the WP templating structure, while this function is moving away from that.
Also, this only works for pages this way, while posts also have the singular template in the WP hierarchy.
Unfortunately building this for posts as well will also result in inconsistent results because of custom post types not having the same behaviours then.
This exception feature is not documented anywhere, so the chances are slim that it will break anything on existing sites.
|
Closed by #183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue at hand
front-page.twig wasn't used when a page was set to "front-page" via the WordPress dashboard. This means the Theme Template Hierarchy wasn't followed. We also noticed this with the bug that Niels encountered when a Archive was empty and Clarkson previously fell back to 'index'.
Fixes
Don't replace the minus from the basename of the template. Because this way 'front-page.twig' can be used so the correct template hierarchy can be followed.
Fix finding the correct twig template file.
Don't incorpate own custom logic because the third $templates parameter contains correct template name to search for according to the Theme Hierarchy.
This method, using the $templates array, also considers the egde-case / bug that @NielsdeBlaauw encoutered: Load the correct archive.twig template when you visit the archive page but there are not Posts in that archive. This because WordPress already take this in account and we now really follow the WordPress flow by using $templates array.
Based on #99 but with some extra documentation, checks and fallbacks. Also tested with variety of possible templates.
Backwards compatibilty
Is this code backwards compatible. I do think so, because the issue of not being able to use front-page.twig was often fixed by using a custom page template and applying that to the page. But please enlighten me if that's not the case.