Skip to content

Commit

Permalink
Upgrade Jane Street packages to v0.18~preview.130.00+55
Browse files Browse the repository at this point in the history
  • Loading branch information
leviroth committed Nov 11, 2024
1 parent 92e7052 commit 0aa5112
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion reddit_api_async/connection.ml
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ module Local = struct
t.access_token <- Outstanding_request ivar;
let%bind result = get_token cohttp_client_wrapper t.credentials ~time_source in
t.access_token <- No_outstanding_request (Result.ok result);
Ivar.fill ivar result;
Ivar.fill_exn ivar result;
return result
in
let%bind result =
Expand Down Expand Up @@ -531,6 +531,7 @@ module Remote = struct
~bin_query:[%bin_type_class: Endpoint.Sequencer.t option * Uri.t]
~bin_response:
[%bin_type_class: (Cohttp_response.t * string, Exn.t Error.t) Result.t]
~include_in_error_count:Result
;;

let post_form =
Expand All @@ -542,6 +543,7 @@ module Remote = struct
Endpoint.Sequencer.t option * Uri.t * (string * string list) list]
~bin_response:
[%bin_type_class: (Cohttp_response.t * string, Exn.t Error.t) Result.t]
~include_in_error_count:Result
;;
end

Expand Down Expand Up @@ -588,6 +590,7 @@ module Remote = struct
Rpc.Implementations.create_exn
~implementations:[ get; post_form ]
~on_unknown_rpc:`Close_connection
~on_exception:Close_connection
;;

let serve t ~where_to_listen =
Expand Down
4 changes: 2 additions & 2 deletions reddit_api_async/retry_manager.ml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ let on_permanent_response t =
match t.state with
| Working_normally -> ()
| Waiting_for_issue_resolution { finished } ->
Ivar.fill finished ();
Ivar.fill_exn finished ();
t.state <- Working_normally
;;

Expand All @@ -114,7 +114,7 @@ let check_server t =
match Permanent_error.classify_response response, t.state with
| Permanent _, Working_normally -> return (`Finished ())
| Permanent _, Waiting_for_issue_resolution { finished } ->
Ivar.fill finished ();
Ivar.fill_exn finished ();
t.state <- Working_normally;
return (`Finished ())
| Transient_error, Working_normally ->
Expand Down

0 comments on commit 0aa5112

Please sign in to comment.