Collect reviews as an input for index 'active' #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only commits are considered as an index of active, this patch includes other information such as comments and reviews...
levitte
requested changes
Jul 25, 2018
|
|
||
| my $date = DateTime->new(year => $year, month => $month, day => $day); | ||
| my $desired_dow = 7; # Sunday | ||
| $date->subtract(days => ($date->day_of_week - $desired_dow) % 7); |
There was a problem hiding this comment.
Hmmm, isn't that equivalent to days => $date->day_of_week % 7 in this case?
There was a problem hiding this comment.
Right, what you suggested is more perl native ;-)
There was a problem hiding this comment.
Ahh, I misunderstood you. But yes, that is equivalent to what you wrote...
|
Good catch on setting |
|
I'm wondering one thing, though... why not |
I guess the former one is adequate... |
As what the title said...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only commits are considered as an index of active, this patch
includes other information such as comments and reviews...
Note: This patch is rather rough, feel free to improve/edit/or whatever necessary...
Also, I noticed the active index is calculated based on the weeks which have 'active data', not all 'natural ' weeks in a given date period, is it designed so?