Apply a suggested fix I left for myself on Github

lexidor · Dec 24, 2023 · 0d0a265 · 0d0a265
1 parent 0d92f35
commit 0d0a265
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/__Private/codegen/CodegenSyntax.hack b/src/__Private/codegen/CodegenSyntax.hack
@@ -760,7 +760,8 @@ final class CodegenSyntax extends CodegenBase {
     $is_a_known_type = $is_node_listy && $rest === '<Node>' ||
       $is_list_itemy && $rest === '<?Node>';
 
-    return
-      $is_a_known_type ? $expression.' as '.$open_generic : $best_effort_fixme;
+    return $upper_bound === $expected_type
+      ? $expression.' as '.$open_generic
+      : $best_effort_fixme;
   }
 }