feat: add TDEngine v3 sink(#2054) #3543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3543 +/- ##
==========================================
- Coverage 71.17% 71.14% -0.03%
==========================================
Files 417 419 +2
Lines 48167 48308 +141
==========================================
+ Hits 34279 34365 +86
- Misses 11213 11264 +51
- Partials 2675 2679 +4 ☔ View full report in Codecov by Sentry. |
Dream95
force-pushed
the
feat_tdeneing3_sink
branch
4 times, most recently
from
512f40b to
9d53f3a
Compare
|
How should I perform unit testing on the 'connect' method? |
|
@ngjaying please review the merge |
Thanks. We will review this. Notice that, we are now code freeze for new features. We can only merge this after v2.1 release. |
|
Additionally, is it possible to add more test coverage? Thanks. |
Signed-off-by: Dream95 <[email protected]>
Dream95
force-pushed
the
feat_tdeneing3_sink
branch
from
9d53f3a to
4cf0e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.