mini-yetus: a yetus you fall in love with #4188
Conversation
tools/mini-yetus.sh
Outdated
| --patch-dir=/src/yetus-output > /dev/null 2>&1 | ||
|
|
||
| echo "[+] Results:" | ||
| cat "$SRC_DIR/yetus-output/results-full.txt" |
There was a problem hiding this comment.
IMHO we should let the users decide to which files they want to look at it and remove the output by themselves... in my case I go directly to the result file I'm interested, e.g., results-shellcheck.txt or results-golangcilint.txt, here it's enforced to always get the full results and remove the output dir, sometimes users can also want to keep the results saved....
tools/mini-yetus.sh
Outdated
| @@ -0,0 +1,68 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I didn't see any "bashism" in the script to enforce bash... better to keep /bin/sh....
There was a problem hiding this comment.
Are you bashing my script? may the /bin/sh be with you!
|
btw the result is clickable if using something like VSCode. |
|
The CI version of Yetus tries its best to stop the new competitor: |
|
I also have a suggestion: could we add the mini-yetus run as a Makefile target? |
| @@ -0,0 +1,106 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
almost none of the files in tools have it, I though that's the tradition :D
There was a problem hiding this comment.
I don't think it was an intentional tradition =)
There was a problem hiding this comment.
oh no "Linux Foundation".
shjala
force-pushed
the
love_yetus
branch
2 times, most recently
from
01e4dc2 to
e60f7fb
Compare
|
|
||
| # copy all the dot files from root to the SRC_DIR, this includes all | ||
| # the yetus configuration files. | ||
| find . -maxdepth 1 -type f -name '.*' -exec cp --parents {} "$SRC_DIR/" \; |
|
if anyone has a better suggestion for |
| @@ -459,6 +459,10 @@ yetus: | |||
| --plugins=all \ | |||
| --patch-dir=/src/yetus-output | |||
|
|
|||
| mini-yetus: | |||
|
Ah, sorry for the failure of the new linter. Just rebase on the latest master |
Add script to run yetus only on changes made in the current branch against the master branch. This is much faster than running yetus on the entire codebase. Signed-off-by: Shahriyar Jalayeri <[email protected]>
Add script to run yetus only on changes made in the current branch against the master branch. This is much faster than running yetus on the entire codebase. Now you can do
make mini-yetus!