Remove perl from installer image. #4594
Conversation
perl was part of PKGS, i.e. it was available both during build and during the final image. But perl is not needed in the final image. Removes it. Signed-off-by: Avi Deitcher <[email protected]>
|
This does require a proper test. |
|
Also, I checked for usage of perl in the installer container and in the single mounted file from |
|
I am running an installer test right now. Will comment when done. |
Are you planning to do it? =) |
yeah, see above. |
There was a problem hiding this comment.
Looks good, but @rucoder asks to perform a proper test of the installer before we merge it =)
Got it, thanks! |
|
Worked quite well on my installation test. |
|
Why is |
We have approved it too fast. The builds had not yet been completed. This action depends on completed builds. |
I also see a confirmation from Zeljko that it works fine. Taking into account we do not have any installer-specific tests, I think we're good at merging it without waiting results of all the tests. |
perl was part of PKGS, i.e. it was available both during build and during the final image. But perl is not needed in the final image. Removes it.
As a comparison, I created both images on x86_64 with
docker build, thendocker create, thendocker exportto see what the tarred up filesystem size is without compression:So this PR saves 34MB from the installer container and final installer image. In installer raw, it is squashfs, so it matters somewhat less, but for the ISO, this saved 34MB out of the ~800MB of the total, or just under 5%. Not bad for removing a single word from the Dockerfile.