Devel #54
Merged
Devel #54
+3,207
−3,099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Close #47 * This also renames the `track_var_change` / `.track_var_change` arguments in `seq_disperse()` and `seq_disperse_df()`. The arguments with the old names are deprecated.
* For the upcoming `is.atomic(NULL)` --> `FALSE` change, although likely not necessary.
* This is for `duplicate_tally()`. It may be confusing to have the original column names (those without `_n`) listed under `"term"`: users may get the impression that the original columns are summarized instead of the `_n` columns.
* Imports is the suitable place because installation of these packages is not checked. * The ellipsis package was removed altogether: scrutiny only relied on it in versions before 0.3.0. * `"!!!"` is now a global variable because it looks like a function called in the code syntactically.
* This further restricts the input that `audit_seq()` and `reverse_map_seq()` can take. * The new limitation will remain in place until reconstruction of original values after arbitrary dispersion is implemented. Such a solution will be nontrivial and might require storing information about `dispersion` in metadata of the tibble returned by the sequence mappers.
* Compile-time metaprogramming instead of checking at runtime. * This also adds the `.name_key_result` argument.
* This is for performance. * One test is adjusted to this change: it used to check for names, but they were added spuriously in the test object (`df2_rows_1_3_expected`). Since the new test object was created using `constructive::construct()` instead of `dput()`, it looks a little different from before.
Misc cleanup
* It used to be `count` but is now `frequency`. * This is better because it's a widely used term for this exact concept. * As a welcome side effect, this solves the problem that the main result column in the output of `duplicate_count_colpair()` was also named `count`, creating a potentially misleading homonymy: this word used to mean two rather different things in the two functions. * The latter problem used to be explained in the duplicates vignette. It no longer is because the problem disappeared. * Also, `duplicate_count()` was optimized a little.
* They were meant to save memory, but in the cases I benchmarked, they didn't. Instead, they slowed the code down. * Also, `check_args_disabled()` was lightly refactored.
* Renaming two other vignettes: one to disambiguate, the other for consistency.
* This is for performance. * Writing the new code like `any(multiple_values == single_value)`, which is more readable than the reverse.
* Now returning a tibble with 30 instead of 60 rows in order not to breach the five-seconds limit of R-CMD-check. * Also, fixed a typo in the docs of all three sequence mappers.
* Also, newly generated the `grim_raster_*` objects. * They may look different in a few places now because this is the first rendering since "dust" was added in `grim_scalar()`, especially if `rounding` is `"up"` or `"down"`: the white vertical lines are now gone, although they still exist with the default `"up_or_down"`.
* Also, some more polishing in the docs.
* Add `scrutiny_prefix` param. * Support bracket links, as the rest of scrutiny now does. * Use in the docs of `function_map_seq()` and `function_map_total_n()`.
* It's designed for short vignettes that are essentially abstracts of much longer ones. * This starts with the two new articles on rounding and consistency test implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.