Devel #70
Merged
Devel #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `use_standalone("r-lib/rlang", file = "types-check")`
* With the previous commit, it is no longer needed.
* This also reverses the deprecation of `tolerance` in `grim_items()`.
* Temporary measure as a step on the way to re-implementing GRIMMER in scrutiny.
This also includes: * Deprecating the `show_prob` argument * Renaming two columns returned by the corresponding `audit()` method * A little refactoring of `grim_map()`
* This is purely an automatic translation of variable names. * To wit, the idea is to incorporate a modified version of `rsprite2::GRIMMER_test()` into scrutiny. The process starts with choosing more idiomatic variable names.
* Not planning to take on the checkmate dependency -- it seems like a nice package, but with a strange license. * In particular, `x` needs to be a string. I should manage this in a way similar to `grim_scalar()`.
* Include link to the Shiny app * Remove less important paragraph -- too much text overall.
These objects were implemented differently from rsprite2: * `p10` * `sum_squares_lower` * `sum_squares_upper`
* Fix #58 * The `items` fix was added earlier, but now I am confident in the overall implementation. * Some questions about disagreements between the implementations remain, but they are likely about GRIM, not GRIMMER; see the new "Resolve disagreements" section in test-grimmer.R
* They led to hard bugs * They were not really necessary
* It's never needed as a separate variable.
* Using `rhub::rhub_setup()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.