-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green on macOS native ruby, macOS homebrew ruby, Ubuntu 18.04 & Ubuntu 20.04 ruby 2.6, 2.7, & 3.0 #311
base: master
Are you sure you want to change the base?
Conversation
ef56a14
to
3cf355a
Compare
This is often bundled with ruby, but not always.
No more warnings, yay.
69978f7
to
c08a5e7
Compare
macos is disabled for now, as it's crashy, as per patch trigger.
LibreSSL uses a mostly OpenSSL 1.0.1 compatible API, with the alarmingly notable exception of the version API. When the library is loaded on macOS with LibreSSL the verison check introduced in lian#42 the gem was incompatible with LibreSSL. This change may not be ideally forward-compatible if APIs change and may need a new strategy eventually, but is not noticeably weaker than the version based strategy. It is notably functional on both macOS with LibreSSL 2.8.3, as well as remaining compatible with OpenSSL 1.1.1f on Ubuntu.
43581b7
to
b69b655
Compare
On macOS the library load is handled in a specific and incompatible way, which is handled by the extension. As the gem uses the extension elsewhere, taking a direct dependency on that, and looking up symbols from in-process should be safe and sufficient.
is this going to be merged? @lian |
I mailed @lian last year, I'm not sure if they're still around. I recently reached out to Penelope who is the other owner of the gems on rubygems.org to see if they'd provide me release rights. I've not received a response from them yet either, so once I've waited a little longer I may start the process with rubygems.org directly. |
hey, i could merge this and release a new gem version. but this library is stale and didn't receive any bitcoin (or any coin) related protocol/feature updates since 2018/2019. how is this code still useful for you guys? |
@lian Any progress is better than no progress? :) Easier to build on top of a working version. |
Its basically the only ruby library that can make and sign txns that I found, and it seems to work fine, and I have pushed several txns to the network that were made by this gem and they worked fine. |
This is a dependency for hive-ruby: |
Summary of changes included:
require 'openssl'