-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error when stitching fails #4072
base: devel
Are you sure you want to change the base?
Conversation
I like the idea, but it looks like we're interfering here with higher-level error handling in MOOSE CI. |
We could probably add a try/catch there to be able to add compatibility with this with a smooth transition? |
I would definitely need to test this before we could merge. I think there may be some situations where we rely on the current behavior of not throwing an error when nothing is stitched. |
I'll go ahead and try adding a try/catch. Also I know users often ignore warnings but if there are cases where it relies on it not throwing an error then maybe making it a warning instead might work? |
I could be talked into a warning. Not literally |
In no matching nodes are found, libmesh throws an error now refs idaholab/moose#27758
1cb8d73
to
c4f02bf
Compare
Sorry this took so long, but I changed it to a warning statement (using libmesh::out). I was going to do a try/catch but I think that might still interfere with MOOSE's error handling? |
When no matching nodes are found, libmesh throws an error now
refs idaholab/moose#27758