Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error when stitching fails #4072

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

DanielYankura
Copy link

@DanielYankura DanielYankura commented Feb 6, 2025

When no matching nodes are found, libmesh throws an error now

refs idaholab/moose#27758

@roystgnr
Copy link
Member

roystgnr commented Feb 7, 2025

I like the idea, but it looks like we're interfering here with higher-level error handling in MOOSE CI.

@roystgnr
Copy link
Member

roystgnr commented Feb 7, 2025

We could probably add a try/catch there to be able to add compatibility with this with a smooth transition?

@moosebuild
Copy link

moosebuild commented Feb 7, 2025

Job Coverage, step Generate coverage on c4f02bf wanted to post the following:

Coverage

5b27fa #4072 c4f02b
Total Total +/- New
Rate 62.51% 62.51% +0.00% 100.00%
Hits 72994 72996 +2 2
Misses 43779 43778 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@jwpeterson
Copy link
Member

I would definitely need to test this before we could merge. I think there may be some situations where we rely on the current behavior of not throwing an error when nothing is stitched.

@DanielYankura
Copy link
Author

I'll go ahead and try adding a try/catch. Also I know users often ignore warnings but if there are cases where it relies on it not throwing an error then maybe making it a warning instead might work?

@roystgnr
Copy link
Member

I could be talked into a warning. Not literally libmesh_warning(), but something informative to libMesh::out.

In no matching nodes are found, libmesh throws an error now

refs idaholab/moose#27758
@DanielYankura
Copy link
Author

Sorry this took so long, but I changed it to a warning statement (using libmesh::out). I was going to do a try/catch but I think that might still interfere with MOOSE's error handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants