Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sha algorithm, fix perf test drift, comments. #1555

Merged
merged 4 commits into from
Nov 26, 2024
+590 −2,979
Merged

Refactor sha algorithm, fix perf test drift, comments. #1555

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3443ea2
Fix drift in disabled perf tests.
evoskuil Nov 25, 2024
fddf944
Refactor sha algorithm, remove dead code.
evoskuil Nov 26, 2024
0d700f1
Add native sha compression.
evoskuil Nov 26, 2024
70af8b1
Disable compress_native.
evoskuil Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable compress_native.
@evoskuil
evoskuil committed Nov 26, 2024
commit 70af8b16ef1c0eff6e48e4f9bd3cc764ba50709a
13 changes: 7 additions & 6 deletions include/bitcoin/system/impl/hash/sha/algorithm_native.ipp
View file
Original file line number Diff line number Diff line change
@@ -288,14 +288,15 @@ template <size_t Lane>
INLINE void CLASS::
compress_native(state_t& state, const buffer_t& buffer) NOEXCEPT
{
// TODO: debug.
// TODO: sha160 state is too small to array cast into two xwords.
// neon and sha160 not yet implemented, sha512 is not native.
if constexpr (SHA::strength == 256 && !use_neon)
{
compress_native<Lane>(array_cast<xint128_t>(state),
array_cast<xint128_t>(buffer));
}
else
////if constexpr (SHA::strength == 256 && !use_neon)
////{
//// compress_native<Lane>(array_cast<xint128_t>(state),
//// array_cast<xint128_t>(buffer));
////}
////else
{
compress_<Lane>(state, buffer);
}
Loading