Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHL: skip tests on CPython 3.13 for now (wait for numpy wheels) #156

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Aug 13, 2024

Rationale:
Following upstream changes in cibuildwheel, our wheels are being tested on CPython 3.13 too, but it doesn't quite work since numpy doesn't have stable wheels for it yet.

Originally posed in #155: #155 (comment)

example logs

Currently based off #155

@neutrinoceros neutrinoceros changed the title WHL: skip tests on CPython 3.13 for now (wait for numpy wheels) WHL: skip tests on CPython 3.13 for now (wait for numpy wheels) (⏰ wait for #155) Aug 13, 2024
@neutrinoceros neutrinoceros changed the title WHL: skip tests on CPython 3.13 for now (wait for numpy wheels) (⏰ wait for #155) WHL: skip tests on CPython 3.13 for now (wait for numpy wheels) Aug 13, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review August 13, 2024 21:42
@neutrinoceros
Copy link
Contributor Author

@mhvk this is ready for review !

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's go with this so that builds are green again. Thanks!

@mhvk mhvk merged commit fd677bd into liberfa:main Aug 14, 2024
24 checks passed
@neutrinoceros neutrinoceros deleted the whl/skip_test_cp313 branch August 15, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants