⚡ Optimize #26
Merged
⚡ Optimize #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ♻️ Simplify `restore_cpu_core` assembly a bit - ⚡ Unwind becomes a jump table
- ⚡ Carve out a branch for decoding uleb128 call-site information, the most common and encouraged encoding. - 🐛 Add `lr` and `pc` to clobber list to ensure that the compiler does not attempt to use the `lr` register to hold the pointer to the virtual_cpu structure - ⚡ Move index entry definitions to the header
I was trying to make a version of the `enter_function()` function that has less branches. Trading space for speed.
`enter_function2()` will be a replacement for `enter_function()`. This function correctly decodes the call sites using their encoding values and decodes the action table and type table correctly as well. Although the type table parsing is still assumed to be pcrel. This should be fixed at some point.
The idea of unwind_frame2 was to evaluate the instructions in place vs putting them into order in the instruction_t. The problem is word boundaries which requires logic to determine if we are at the end of the instructions.
- Remove a few `#if 0` code - Slightly fix up issues with CI
|
Merging even though Mac is being silly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.