-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade dependencies. #233
Conversation
I see we removed the On the other hand, I'm not quite sure it even makes to have that API in the DHT and if it's implementation was even correct. Can I go ahead and remove this API from |
So now it's impossible to write a crawler? |
Nope, crawlers are working just fine and people keep making more of them. Now that routing table membership is disassociated from connection state using only a view of connected peers is both an unnecessary information leak and will result in an incorrect view of the network. Looking through open source projects (e.g. https://grep.app/search?q=.FindPeersConnectedToPeer&case=true&filter[lang][0]=Go) there does not seem to be any external community members trying to do anything useful with this other than just re-expose the functionality like this libp2p-daemon does. @vyzo did you have any other use case in mind that would warrant re-exposing this internal state?
Yes |
No, it was only useful for crawling and diagnosing the network. |
@raulk depending on what people actually use the libp2p-daemon for I'd probably switch the DHT to use the |
Hey all! IPFS is experiencing some interop issues with the latest gossipsub work . Some references: I would like to get the interop tests running on cc @achingbrain |
kvalue has nothing to do with the number of providers a user might want and this constant has been removed from the DHT.
This feature has been removed from the DHT and supporting this feature here was an historical mistake. We need to move towards abstracting over an abstract "router" type instead of hard-coding DHT concepts.
Doesn't build due to go-libp2p-kad-dht API breaking changes.