feat(transport/websocket): support SOCKS proxy with wss #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
changed the title
|
lgtm 👍 I guess setEnv doesn't work in CI? |
|
I didn't really debug, but SetEnv might be surprising if other tests are run in parallel. |
huh I was fairly certain that SetEnv only affects the current process and children, though I guess the tests may run in the same process as separate goroutines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #286 (a 7 year old issue??)
This PR allows users to use a SOCKS5 proxy when dialing
/wssaddresses by using theHTTPS_PROXYenvironment variable.Here's an example using vole to dial through a socks proxy: