Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overriding stream handlers #2945

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

achingbrain
Copy link
Member

Adds a force flag to libp2p.handle that means the method will not throw if a handler already exists for the protocol being handled.

Fixes #2928

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner February 6, 2025 07:19
Adds a `force` flag to `libp2p.handle` that means the method will
not throw if a handler already exists for the protocol being handled.

Fixes #2928
@achingbrain achingbrain force-pushed the feat/allow-overriding-handlers branch from 1654573 to 06750d1 Compare February 6, 2025 07:24
@achingbrain achingbrain merged commit 21088c5 into main Feb 6, 2025
32 checks passed
@achingbrain achingbrain deleted the feat/allow-overriding-handlers branch February 6, 2025 07:40
@achingbrain achingbrain mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility between handle tsdoc and implementation
1 participant