-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove simple::SimpleProtocol #3191
Conversation
Due to lack of usage, remove the `simple::SimpleProtocol`. Users may look at `libp2p::core::upgrade` for alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uhm, good question. This discussion discussion suggests |
Co-authored-by: João Oliveira <[email protected]>
Testground failure is due to a rename:
See #2647 (comment) for |
Fix is here: #3203 |
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
For |
Description
Due to lack of usage, remove the
simple::SimpleProtocol
. Users may look atlibp2p::core::upgrade
for alternatives.Notes
Discovered through @umgefahren's
master
docs (#3126).Links to any relevant issues
Open Questions
Change checklist