Skip to content

Commit

Permalink
fix(pubsub): remove "Implementation note" about setting `message_id_f…
Browse files Browse the repository at this point in the history
…n` (#557)
  • Loading branch information
cce authored Jul 16, 2023
1 parent 19a545b commit f5c5829
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions pubsub/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,6 @@ on the [signature policy](#signature-policy) configured for the topic.**
Whichever the choice, it is crucial that **all peers** participating in a topic
implement identical message ID calculation logic, or the topic will malfunction.

> **[[ Implementation note ]]:** At the time of writing this section,
> go-libp2p-pubsub (reference implementation of this spec) only allows
> configuring a single top-level `message_id_fn`. This function may, however,
> vary its behaviour based on the topic (contained inside its `Message`)
> argument. Thus, it's feasible to implement a per-topic policy using branch
> selection control flow logic. In the near future, go-libp2p-pubsub plans to
> push down the configuration of the `message_id_fn` to the topic level. Other
> implementations are encouraged to do the same.
## Message Signing

Signature behavior is configured in two axes: signature creation, and signature
Expand Down

0 comments on commit f5c5829

Please sign in to comment.