#246 Fix for inappropriate disposal #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyhac
commented
May 7, 2022
| @@ -7,7 +7,12 @@ namespace NativeImport_Examples | |||
| { | |||
| public struct MyUserDataClass | |||
| { | |||
| public int Value = 1234; | |||
There was a problem hiding this comment.
This is unrelated to the primary change. Without it the code doesn't compile
|
Started to look at this, but I'm going to need to pull the whole code to think through how it interacts... |
|
Alright went through it a little more. This makes sense, I think. I still haven't quite internalized how the whole ConcurrentStack is used with the native code and the TCS. What's up with the broken build and the new GH action? |
jkoplo
approved these changes
May 28, 2022
|
I think it's this #255 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes inappropriate disposal (for tags that failed to initialize using InitializeAsync).
When InitializeAsync ReadAsync or WriteAsync times out, it also will ensure that it will fail with a ErrorTimeout as opposed to a ErrorAborted