-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wifi-unstuck-wa: allow parametrizable values for interval and timeout #1039
wifi-unstuck-wa: allow parametrizable values for interval and timeout #1039
Conversation
…example; lime-system: add default values
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 79.27% 79.74% +0.46%
==========================================
Files 53 53
Lines 4444 4532 +88
==========================================
+ Hits 3523 3614 +91
+ Misses 921 918 -3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Instead of modifying the source code with sed inside an uci-defaults script, maybe it would be better to put the content of the hook_wireless.lua.txt file directly in
? Though it moves something that conceptionally belongs to the package wifi-unstuck-wa into the lime-system package. Alternatively you could put just after the line lime-packages/packages/lime-system/files/usr/lib/lua/lime/config.lua Lines 204 to 205 in 861f7bd
something like
and equip the wifi_unstuck_wa.lua file with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on openwrt-22.03.5-ath79-generic-tplink_cpe510-v3 |
This close #1034