links information according to batman protocol #1055

javierbrk · 2023-09-26T17:54:31Z

This module provides per interface links information associated with batman protocol basically using batclt nj command as source. The output is similar to the wifi_links_info to make data parsing easy.

This module depends on batctl-default witch is in use by kmod-batman-adv and batman-adv-auto-gw-mode.

This is a sample output of the command shared-state-async get bat_links_info run in one of two librerouters.

{
    "lrprimero": [
        {
            "dst_mac": "02:29:0f:1f:73:aa",
            "last_seen_msecs": 770,
            "tq": 238,
            "src_mac": "02:29:0f:1f:72:3a",
            "iface": "eth1-2_250"
        },
        {
            "dst_mac": "02:db:d6:fc:3a:bd",
            "last_seen_msecs": 510,
            "tq": 155,
            "src_mac": "02:29:0f:1f:72:3a",
            "iface": "eth1-2_250"
        }
    ],
    "lrsegundo": [
        {
            "dst_mac": "02:db:d6:fc:3a:bd",
            "last_seen_msecs": 480,
            "tq": 255,
            "src_mac": "02:29:0f:1f:73:aa",
            "iface": "eth1-2_250"
        },
        {
            "dst_mac": "02:29:0f:1f:72:3a",
            "last_seen_msecs": 750,
            "tq": 254,
            "src_mac": "02:29:0f:1f:73:aa",
            "iface": "eth1-2_250"
        }
    ]
}

codecov-commenter · 2023-09-26T17:57:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (6992335) to head (1c099ca).

❗ Current head 1c099ca differs from pull request most recent head 1e1f379. Consider uploading reports for the commit 1e1f379 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   79.54%   79.68%   +0.14%     
==========================================
  Files          53       53              
  Lines        4566     4574       +8     
==========================================
+ Hits         3632     3645      +13     
+ Misses        934      929       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ilario · 2023-09-27T08:13:56Z

Great!

Just one comment:

$RANDOM will not be available in the upcoming LibreMesh releases.
See #800 and #991 (this means that the makefile should include a dependency from the replacement package and the uci-default package should include the random-numgen command instead of the $RANDOM)

G10h4ck

hard_ifindexshould be removed, it is an internal index not useful for other nodes or the used, and better to not spread it around. Plus see my comments inline.

G10h4ck · 2023-10-04T07:41:21Z

packages/shared-state-bat_links_info/tests/test_shared-state-bat_links_info.lua

+        assert.are.equal(1990, links_info[1].last_seen_msecs)
+        assert.are.equal("wlan0-mesh_250", links_info[1].iface)
+    end)
+end)


New line missing at the end of file

javierbrk · 2023-10-10T19:54:46Z

The last push includes the tq parameter for every neighbor

G10h4ck

See inline comments

G10h4ck · 2023-10-12T08:58:19Z

packages/shared-state-bat_links_info/files/usr/bin/shared-state-publish_bat_links_info

+function get_bat_links_info()
+	local batneights_obj={}
+	local batlinks_obj={}
+	local batlinks = utils.unsafe_shell("batctl oj")


they aren't links, but all the nodes in the network and their distance, we could keep this variable and derivative named bat_originators_*

G10h4ck · 2023-10-12T09:03:40Z

packages/shared-state-bat_links_info/files/usr/bin/shared-state-publish_bat_links_info

+			if link_value.hard_ifname == neight_value.iface and 
+			link_value.neigh_address== link_value.orig_address and  
+			link_value.neigh_address== neight_value.dst_mac then
+				neight_value.tq = link_value.tq


Let's add a comment explaining that tq stands for Batman Transmit Quality

G10h4ck · 2024-02-08T18:07:10Z

should be ported to shared-state-async before merging

ilario · 2024-03-01T13:57:46Z

At some point in the future, when we will have BATMAN_V working (the possibility to select it was introduced in #1004 as @lindnermarek said it is better than BATMAN_IV. But the first tests failed, as reported on #1059 . The progress on this is being tracked here: #1009 ), we should check if this works also for BATMAN_V.

…

-- Inviato dal mio smartstone

javierbrk · 2024-03-04T15:30:21Z

At some point in the future, when we will have BATMAN_V working (the possibility to select it was introduced in #1004 as @lindnermarek said it is better than BATMAN_IV. But the first tests failed, as reported on #1059 . The progress on this is being tracked here: #1009 ), we should check if this works also for BATMAN_V.
…
-- Inviato dal mio smartstone

Nice ! this package gets info from batctl, I made a small poc and saw that if the network uses batmanV the json changes to this, instead of "tq" you get "throughput" and the information is directly in the originators table.

{
    "lrprimero": [
        {
            "last_seen_msecs": 430,
            "src_mac": "02:29:0f:1f:72:3a",
            "throughput": 1000000,
            "dst_mac": "02:29:0f:1f:73:aa",
            "iface": "eth1-2_250"
        }
    ],
    "lrsegundo": [
        {
            "last_seen_msecs": 310,
            "src_mac": "02:29:0f:1f:73:aa",
            "throughput": 1000000,
            "dst_mac": "02:29:0f:1f:72:3a",
            "iface": "eth1-2_250"
        }
    ]
}

javierbrk and others added 8 commits September 22, 2023 16:32

intial module structure

82a3892

added batman link information publisher

2fdda95

removed debug prints

1aed507

consistent renaming

db4a0fd

fixed folder name

9ee9922

Added test case

79e7dba

removed unused file

ad077f4

Add batctl dependency

947e962

javierbrk added this to the mesh-wide milestone Sep 26, 2023

Fixed makefile title

f89fbd2

G10h4ck requested changes Oct 4, 2023

View reviewed changes

javierbrk added 3 commits October 4, 2023 09:13

removed hard_ifindex and added new line at the end of file

3d86203

remove debug print

18d70c7

add link tq parameter and optional best indicator

6817c8c

javierbrk marked this pull request as draft October 5, 2023 11:56

javierajorge added 2 commits October 10, 2023 16:17

package refactoring to include tq index

f6aa83f

include mac verification in tests

6d4c609

javierbrk marked this pull request as ready for review October 10, 2023 19:59

G10h4ck requested changes Oct 12, 2023

View reviewed changes

name refactoring and comments

3d63187

G10h4ck changed the title ~~links information acording to batman protocol~~ links information according to batman protocol Feb 8, 2024

javierbrk and others added 2 commits February 27, 2024 11:03

Merge branch 'libremesh:master' into batmaninfo

934a550

shared-state-async: ads bat links info

1e1f379

javierbrk marked this pull request as draft February 27, 2024 16:43

adds shared state async as aa dependency

30298c7

javierbrk marked this pull request as ready for review March 1, 2024 13:55

G10h4ck approved these changes Mar 12, 2024

View reviewed changes

G10h4ck merged commit 069ac1a into libremesh:master Mar 12, 2024
1 check passed

javierbrk deleted the batmaninfo branch December 11, 2024 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

links information according to batman protocol #1055

links information according to batman protocol #1055

javierbrk commented Sep 26, 2023 •

edited

Loading

codecov-commenter commented Sep 26, 2023 •

edited

Loading

ilario commented Sep 27, 2023

G10h4ck left a comment

G10h4ck Oct 4, 2023

javierbrk Oct 4, 2023

javierbrk commented Oct 10, 2023

G10h4ck left a comment

G10h4ck Oct 12, 2023

javierbrk Oct 12, 2023

G10h4ck Oct 12, 2023

javierbrk Oct 12, 2023

G10h4ck commented Feb 8, 2024

ilario commented Mar 1, 2024 via email

javierbrk commented Mar 4, 2024

links information according to batman protocol #1055

links information according to batman protocol #1055

Conversation

javierbrk commented Sep 26, 2023 • edited Loading

codecov-commenter commented Sep 26, 2023 • edited Loading

Codecov Report

ilario commented Sep 27, 2023

G10h4ck left a comment

Choose a reason for hiding this comment

G10h4ck Oct 4, 2023

Choose a reason for hiding this comment

javierbrk Oct 4, 2023

Choose a reason for hiding this comment

javierbrk commented Oct 10, 2023

G10h4ck left a comment

Choose a reason for hiding this comment

G10h4ck Oct 12, 2023

Choose a reason for hiding this comment

javierbrk Oct 12, 2023

Choose a reason for hiding this comment

G10h4ck Oct 12, 2023

Choose a reason for hiding this comment

javierbrk Oct 12, 2023

Choose a reason for hiding this comment

G10h4ck commented Feb 8, 2024

ilario commented Mar 1, 2024 via email

javierbrk commented Mar 4, 2024

javierbrk commented Sep 26, 2023 •

edited

Loading

codecov-commenter commented Sep 26, 2023 •

edited

Loading