re-implement shared-state from scratch in modern C++ #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G10h4ck
force-pushed
the
shared_state_async
branch
from
1598b10 to
484f7bb
Compare
G10h4ck
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
- Coverage 79.69% 79.55% -0.14%
==========================================
Files 53 53
Lines 4550 4549 -1
==========================================
- Hits 3626 3619 -7
- Misses 924 930 +6 ☔ View full report in Codecov by Sentry. |
G10h4ck
changed the title
selankon
requested changes
Jan 23, 2024
Comment on lines
+4
to
+39
| -- local utils = require('lime.utils') | ||
| -- local test_utils = require('tests.utils') | ||
| -- local shared_state = require('shared-state') | ||
| -- | ||
| -- it('test get_bathost #bathost', function() | ||
| -- shared_state.DATA_DIR = test_utils.setup_test_dir() | ||
| -- local sharedState = shared_state.SharedState:new('bat-hosts') | ||
| -- sharedState:insert({ | ||
| -- ["02:95:39:ab:cd:00"] = "LiMe_abcd00_wlan1_mesh", | ||
| -- ["52:00:00:ab:cd:a0"] = "LiMe_abcd01_wlan2_mesh_17", | ||
| -- ["d6:67:58:8e:cd:92"] = "LiMe_abcd02_wlan0_adhoc_29", | ||
| -- ["12:00:00:00:00:00"] = "LiMe_abcd03_wlan1_adhoc" | ||
| -- }) | ||
| -- local ifaces = {'wlan1-mesh', 'wlan2-mesh', 'wlan2-mesh_17', 'wlan0-adhoc_29', 'wlan1-adhoc'} | ||
| -- stub(utils, "get_ifnames", function () return ifaces end) | ||
| -- assert.is.same({hostname='LiMe-abcd00', iface='wlan1-mesh'}, bat_hosts.get_bathost('02:95:39:ab:cd:00')) | ||
| -- assert.is.same({hostname='LiMe-abcd01', iface='wlan2-mesh_17'}, bat_hosts.get_bathost('52:00:00:ab:cd:a0')) | ||
| -- assert.is.same({hostname='LiMe-abcd02', iface='wlan0-adhoc_29'}, bat_hosts.get_bathost('d6:67:58:8e:cd:92')) | ||
| -- assert.is.same({hostname='LiMe-abcd03', iface='wlan1-adhoc'}, bat_hosts.get_bathost('12:00:00:00:00:00')) | ||
| -- local ipv6ll = utils.mac2ipv6linklocal('52:00:00:ab:cd:00') .. '%wlan1-mesh' | ||
| -- local dataTypeOfSync = nil | ||
| -- local urlsOfSync = nil | ||
| -- local function syncMock (self, urls) | ||
| -- dataTypeOfSync = self.dataType | ||
| -- urlsOfSync = urls | ||
| -- self:insert({['52:00:00:ab:cd:00'] = "Lime_abcd04_wlan1_mesh"}) | ||
| -- end | ||
| -- stub(shared_state.SharedState, "sync", syncMock) | ||
| -- local bathost = bat_hosts.get_bathost('52:00:00:ab:cd:00', 'wlan1-mesh') | ||
| -- assert.is.same(urlsOfSync, { ipv6ll }) | ||
| -- assert.is.equal(dataTypeOfSync, 'bat-hosts') | ||
| -- assert.is.same({hostname='Lime-abcd04', iface='wlan1-mesh'}, bathost) | ||
| -- assert.is_nil(bat_hosts.get_bathost('00:aa:bb:cc:dd:00', 'wlan1')) | ||
| -- assert.is_nil(bat_hosts.get_bathost('00:aa:bb:cc:dd:00')) | ||
| -- end) |
There was a problem hiding this comment.
Commented code. Should this tests work?
There was a problem hiding this comment.
nope, because it relies on Lua shared-state
javierbrk
approved these changes
Jan 26, 2024
a-gave
added a commit
to a-gave/lime-packages
that referenced
this pull request
Mar 1, 2024
Add a new packages repository at: - http://github.com/libremesh/lime-feed/tree/gh-pages/master/packages/$ARCH_PACKAGES - http://feed.libremesh.org/master/packages/$ARCH_PACKAGES That includes packages precompiled by openwrt-sdk for each specific architecture This is currently required only for the package 'shared-state-async' After this merge libremesh#1067 imagebuilder builds fail, using the default set of packages, unless you are building for x86_64 update the imagebuilder build guide on README.md update lime-system/files/etc/uci-defaults/92_add-lime-repos to use also the new repo
a-gave
added a commit
to a-gave/lime-packages
that referenced
this pull request
Mar 2, 2024
Add a new packages repository at: - http://github.com/libremesh/lime-feed/tree/gh-pages/master/packages/$ARCH_PACKAGES - http://feed.libremesh.org/master/packages/$ARCH_PACKAGES That includes packages precompiled by openwrt-sdk for each specific architecture This is currently required only for the package 'shared-state-async' After this merge libremesh#1067 imagebuilder builds fail, using the default set of packages, unless you are building for x86_64 update the imagebuilder build guide on README.md update lime-system/files/etc/uci-defaults/92_add-lime-repos to use also the new repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shared-state-async package with almost complete shared-state modern C++ re-implementation, peer discovery is the only things that haven't been implemented yet in C++ and rely still on the shell script copied directly at compile time from the Lua shared-state package.
To show how to port the shared-state plugins to the new implementation also bat-hosts have been ported to the new implementation.