Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eupgrade: set cached_only to false #1070

Closed
wants to merge 1 commit into from

Conversation

selankon
Copy link
Collaborator

Fixes #1069

@selankon selankon requested a review from spiccinini January 25, 2024 09:36
@spiccinini
Copy link
Contributor

Did you try with the lime-app? Forcing no cache will slow the load of the app right @germanferrero ?

@selankon
Copy link
Collaborator Author

@spiccinini the react query that check for updates should not block the ui.

BTW, we could use a background process or something like that, to check the updates, and let this just set to false? I am not familiarized with OWRT systems, have they something similar to services?

@@ -70,4 +70,4 @@ if arg[1] == 'call' then
elseif arg[2] == 'download_status' then download_status(msg)
else utils.printJson({ error = "Method not found" })
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line at the end of file

@G10h4ck
Copy link
Member

G10h4ck commented Feb 5, 2024

I would expect from a function named like that to not return a cached result.
Do the sub-called function trigger the download?
If this change slow down the UI, I would suggest to split triggering the download into another function

@G10h4ck G10h4ck added this to the mesh-wide milestone Feb 5, 2024
@spiccinini
Copy link
Contributor

Do the sub-called function trigger the download?

AFAIK no. The issue is that until the http GET does not return it will block (and if you don't have internet it will timeout in more than a few seconds).

@spiccinini
Copy link
Contributor

@spiccinini the react query that check for updates should not block the ui.

You mean that the current code does not block or that it should not? In some version of the lime-app it blocked the main page of the app, if you tested something like even adding a sleep(30) in the lua file does not block then good!.

@ilario
Copy link
Member

ilario commented Apr 3, 2024

This edit has been included by @selankon in #1101 so I would close this pull request.
If you consider that the discussion was not finished and that the change should be reverted, please re-open this or open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eupgrade is_new_version_available always will return false
4 participants