-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eupgrade: set cached_only to false #1070
Conversation
Did you try with the lime-app? Forcing no cache will slow the load of the app right @germanferrero ? |
@spiccinini the react query that check for updates should not block the ui. BTW, we could use a background process or something like that, to check the updates, and let this just set to false? I am not familiarized with OWRT systems, have they something similar to services? |
@@ -70,4 +70,4 @@ if arg[1] == 'call' then | |||
elseif arg[2] == 'download_status' then download_status(msg) | |||
else utils.printJson({ error = "Method not found" }) | |||
end | |||
end | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line at the end of file
I would expect from a function named like that to not return a cached result. |
AFAIK no. The issue is that until the http GET does not return it will block (and if you don't have internet it will timeout in more than a few seconds). |
You mean that the current code does not block or that it should not? In some version of the lime-app it blocked the main page of the app, if you tested something like even adding a sleep(30) in the lua file does not block then good!. |
Fixes #1069