[beken-72xx] Fix duration rollover in deep sleep #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba2k2
requested changes
Feb 21, 2024
cap9qd
force-pushed
the
fix_sleep_calcs
branch
from
0518e21 to
6117f35
Compare
Cossid
reviewed
Feb 21, 2024
| // Sleep forever | ||
| deep_sleep_param.sleep_time = 0xFFFFFFFF; | ||
| uint64_t sleep_ticks = 32.768 * sleep_duration_ms; | ||
| if (sleep_ticks >= 0xFFFFFFFF) { |
There was a problem hiding this comment.
I think this should still be > instead of >= in case some actually does want to sleep forever (like rely fully on GPIO wakeup).
There was a problem hiding this comment.
Makes sense! Just fix the rollover.
There was a problem hiding this comment.
No, if someone wants it to sleep forever, they won't call lt_deep_sleep_config_timer() in the first place.
There was a problem hiding this comment.
Thinking about it more it wouldn't make sense to call lt_deep_sleep_config_timer() if you want to wait forever for another wake reason. My ESPHome deep_sleep changes only call the lt_deep_sleep_config_timer() function if a sleep_duration is defined in the YAML.
cap9qd
force-pushed
the
fix_sleep_calcs
branch
from
6117f35 to
67ea94f
Compare
cap9qd
force-pushed
the
fix_sleep_calcs
branch
from
67ea94f to
d3fc945
Compare
kuba2k2
approved these changes
Feb 22, 2024
kuba2k2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #230
Tested on several BK7231N devices with ESPHome 2024.1.0-dev.