Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[realtek-ambz2] Define PIN_SERIAL0_RX/TX for wbr3 #299

Merged

Conversation

nmschulte
Copy link

This is necessary; WBR3 is not in the feature/i2c-spi branch, and this fixes about feature/realtek-update without the concerns of feature/i2c-spi -- perhaps I misunderstand the relevant comment, however.

#44 (comment)

baltpeter@a92983a

@kuba2k2
Copy link
Member

kuba2k2 commented Nov 26, 2024

Hi
This file is auto-generated, so it shouldn't be changed. It will get overwritten after every update processed with boardgen.
The ESPHome code is not ready for the fixes introduced in the feature/realtek-update branch, which makes it incorrectly understand the available serial ports.
However, I can merge this PR to that branch as a temporary workaround.

@kuba2k2 kuba2k2 changed the title define PIN_SERIAL0_RX/PIN_SERIAL0_TX for wbr3 [realtek-ambz2] Define PIN_SERIAL0_RX/TX for wbr3 Nov 26, 2024
@kuba2k2 kuba2k2 merged commit 70b82ba into libretiny-eu:feature/realtek-update Nov 26, 2024
2 checks passed
@nmschulte
Copy link
Author

In that case, I'd say merging is unnecessary -- it sounds like I should focus my efforts on ESPHome and working against the changes you mention. Thanks for helping my understanding here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants