High Hz Synchronization #15798
Merged
High Hz Synchronization #15798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes adjustment to driver_adjust_system_rates and related functions to handle Hz skew adjustment for high refresh rates better, especially when using effective refresh modifiers like swap interval or BFI.
Reorder declaration for build fix
JoeOsborn
pushed a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
* High Hz Synchronization Makes adjustment to driver_adjust_system_rates and related functions to handle Hz skew adjustment for high refresh rates better, especially when using effective refresh modifiers like swap interval or BFI. * Reorder for Build Fix Reorder declaration for build fix
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
* High Hz Synchronization Makes adjustment to driver_adjust_system_rates and related functions to handle Hz skew adjustment for high refresh rates better, especially when using effective refresh modifiers like swap interval or BFI. * Reorder for Build Fix Reorder declaration for build fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes adjustment to driver_adjust_system_rates and related functions to handle Hz skew adjustment for high refresh rates better, especially when using effective refresh modifiers like swap interval or BFI.
Currently, not enough 'smart' adjustments are made for core hz multiples, so very often maximum audio skew is checking a core 60.1hz (as an example) against the full 120/240/whatever Hz of the display, and will fail and abort the timing adjustment the vast majority of the time. This is especially bad for BFI, as misalignment with the refresh rate will be a very common source of annoying 'random' flicker. It can still 'fail' in edge cases of very strange settings combinations, but the result of a failure is just the same as before, an abort of the core speed skew adjustment, but now hopefully much less commonly.