increase chunk size for reads/writes under emscripten #15845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeOsborn
added a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under emscripten, we only use MEMFS so all reads/writes are in-memory anyway.
Each read/write seems to return control to JavaScript and take a full frame before returning for another read. For systems with larger save states (e.g. SNES has 800KB+ states), this means it can take 3-4 seconds to save or load a state just because of unnecessary pauses for FS operations.
Accordingly, I've increased the read/write chunk size for states to 16MB.