Fix narrator modes #16179
Merged
Fix narrator modes #16179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viachaslavic
force-pushed
the
fix_narrator_modes
branch
from
a2a2fa8 to
c29c6c7
Compare
viachaslavic
force-pushed
the
fix_narrator_modes
branch
2 times, most recently
from
d6d6438 to
40fd61c
Compare
|
Looks OK to me, tested Linux part with espeak, menu narrator now acts according to user language instead of AI translation language. One nitpick: a comment would be nice for the 2 functions in retroarch.c, as it is not obvious from the code why those 2 are separated. |
|
Just for information for anyone wondering - related fault in earlier builds can be mostly worked around by setting AI Service target language to the same as user language. |
viachaslavic
force-pushed
the
fix_narrator_modes
branch
2 times, most recently
from
8cc3eaf to
e92800a
Compare
viachaslavic
force-pushed
the
fix_narrator_modes
branch
from
e92800a to
726693f
Compare
Done. I also changed the order of the arguments to avoid implicit type conversion by compiler in cases when wrong function is used. |
|
Looks good to me! |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
* Fix narrator * Refactor accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the Accessibility narrator and the AI service narrator.
Related Issues
#15888 (comment)
Reviewers
@DisasterMo @zoltanvb @BarryJRowe