Use CLI shader path for shader dir init if present #16196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If shader is given on command line, use it for directory init. Fixes libretro#16181, shader cycle should now work using the dir of the shader passed to CLI.
zoltanvb
force-pushed
the
cli_shader_cycle
branch
from
a9c9d0a to
77ef6e0
Compare
|
LGTM. It's optional just because sometimes it's easier to start at the top level if you want to change among a bunch of shaders instead of starting buried down in some sub-sub-sub-directory each time. I don't suspect it gets used very often, though, and it might be something to consider removing if we ever go on a 'menu simplification' purge. @HyperspaceMadness do you know any reason why this PR would be a problem? |
|
Just a ping, is there some pending issue with this PR that I need to address? |
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
If shader is given on command line, use it for directory init. Fixes libretro#16181, shader cycle should now work using the dir of the shader passed to CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If shader is given on command line, use it for directory init. Fixes #16181, shader cycle should now work using the dir of the shader passed to CLI.
Related Issues
Fixes #16181
Reviewers
@hunterk maybe - I do not completely understand why "remember last shader dir" is optional and if there is some hidden use case for shader cycling.