Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: Remove hack ignoring configure events #17317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ColinKinloch
Copy link
Contributor

@ColinKinloch ColinKinloch commented Dec 31, 2024

See #17320

Description

This fixes issues (re)introduced by "Fix improperly sized commits (#17309)"
It seems I didn't fully revert my past hacks.

My previous commit reintroduced an issue where the window stay at the size of the splash screen. It also created new issues around the surface being offset when set to fullscreen.

Related Issues

#16198 (comment)

Related Pull Requests

#17309

Reviewers

@Sunderland93

This fixes issues (re)introduced by "Fix improperly sized commits (libretro#17309)"
@Sunderland93
Copy link
Contributor

Checked in Plasma 5.25. Issue is still occur if RetroArch compiled with --disable-libdecor. Also, in KDE Plasma 6.2 this issue is also present if RetroArch compiled with --enable-vulkan

[INFO] [Core]: Версия API libretro: 1, Скомпилирован против API: 1
[INFO] [Core]: Geometry: 320x240, Aspect: 1.333, FPS: 60.00, Sample rate: 48000.00 Hz.
[INFO] [Video]: Set video size to: 960x720.
[INFO] [Wayland]: Registered interface wl_compositor at version 5
[INFO] [Wayland]: Registered interface xdg_wm_base at version 4
[INFO] [Wayland]: Registered interface zxdg_decoration_manager_v1 at version 1
[INFO] [Wayland]: Registered interface wp_viewporter at version 1
[INFO] [Wayland]: Registered interface wp_fractional_scale_manager_v1 at version 1
[INFO] [Wayland]: Registered interface wl_shm at version 1
[INFO] [Wayland]: Registered interface wl_seat at version 8
[INFO] [Wayland]: Registered interface zwp_pointer_constraints_v1 at version 1
[INFO] [Wayland]: Registered interface zwp_relative_pointer_manager_v1 at version 1
[INFO] [Wayland]: Registered interface wl_data_device_manager at version 3
[INFO] [Wayland]: Registered interface zwp_idle_inhibit_manager_v1 at version 1
[INFO] [Wayland]: Registered interface wp_content_type_manager_v1 at version 1
[INFO] [Wayland]: Registered interface wl_output at version 4
[INFO] [Wayland]: Compositor doesn't support the wp_cursor_shape_manager_v1 protocol!
[INFO] [Wayland]: Compositor doesn't support the wp_single_pixel_buffer_manager_v1 protocol!
[INFO] [EGL] Found EGL client version >= 1.5, trying eglGetPlatformDisplay
[INFO] [EGL]: EGL version: 1.5
[INFO] [GL]: Found GL context: "wayland".
[INFO] [GL]: Detecting screen resolution: 1920x1080.
[INFO] [EGL]: Current context: 0x55919e3f9b60.
[INFO] [GL]: Vendor: AMD, Renderer: AMD Radeon RX 570 Series (radeonsi, polaris10, LLVM 15.0.6, DRM 3.49, 6.1.0-28-amd64).
[INFO] [GL]: Version: 4.6 (Compatibility Profile) Mesa 24.2.4-1~bpo12+1.
[INFO] [GL]: Using resolution 960x720.
[INFO] [GL]: Default shader backend found: glsl.
[INFO] [Shader driver]: Using GLSL shader backend.
[INFO] [GLSL]: Checking GLSL shader support ...
[WARN] [GL]: Stock GLSL shaders will be used.
[INFO] [GLSL]: Found GLSL vertex shader.
[INFO] [GLSL]: Found GLSL fragment shader.
[INFO] [GLSL]: Linking GLSL program.
[INFO] [GLSL]: Found GLSL vertex shader.
[INFO] [GLSL]: Found GLSL fragment shader.
[INFO] [GLSL]: Linking GLSL program.
[INFO] [GLSL]: Found GLSL vertex shader.
[INFO] [GLSL]: Found GLSL fragment shader.
[INFO] [GLSL]: Linking GLSL program.
[INFO] [GL]: Using 4 textures.
[INFO] [GL]: Loaded 1 program(s).
[INFO] [GL]: Using GL_RGB565 for texture uploads.
[INFO] [udev]: Pad #0 (/dev/input/event21) supports force feedback.
[INFO] [udev]: Pad #0 (/dev/input/event21) supports 16 force feedback effects.
[INFO] [Joypad]: Found joypad driver: "udev".
[INFO] [Autoconf]: Sony PLAYSTATION(R)3 Controller подключен в порт 1.
[INFO] [Wayland]: Enabling idle inhibitor
[INFO] [Video]: Found display server: "null".

Also there is a very weird issue while window goes to maximize and vice versa:

maximize.mp4

@ColinKinloch ColinKinloch marked this pull request as draft December 31, 2024 20:22
@LibretroAdmin LibretroAdmin marked this pull request as ready for review January 2, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants