net_http refactor #17460
Merged
net_http refactor #17460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to move calls to getaddrinfo() and connect() into net_http_update(). This will make it possible for them to be replaced with non-blocking alternatives later. The net_http calling pattern right now allows callers to create the http_connection_t, call net_http_new() which creates the http_t from the http_connection_t, free the http_connection_t, and then start calling net_http_update(). In order to preserve that, the http_t needs to copy the values out of the http_connection_t on create. This also preserves the http_connection_t values instead of freeing them, so the connection would be able to be used later.
|
The checks include the gitlab CI run: https://git.libretro.com/libretro/RetroArch/-/pipelines/330951 |
| state->response.buflen = 16 * 1024; | ||
| state->response.data = (char*)malloc(state->response.buflen); | ||
| state->response.headers = string_list_new(); | ||
| string_list_initialize(state->response.headers); |
There was a problem hiding this comment.
There's the memleak again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few little improvements that should help both with avoiding blocking the task queue excessively as well as hopefully slightly improving performance and reducing calls to realloc:
This doesn't change any of the APIs or usage. Hopefully it makes the function that does all the work,
net_http_update, a little easier to read and understand; it doesn't really change any of the logic from it though.