Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core fixes #235

Merged
merged 5 commits into from Mar 7, 2019
Merged

Core fixes #235

merged 5 commits into from Mar 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2019 •
edited by ghost
Loading

958c981 Fix CD audio not playing on some platforms

79f29e0 Fix detection for rumble interface

  • rumble interface is always assumed is available, causing it to crash when rumble core option is left to enabled (default). This detects if rumble interface is available before sending rumble states.

0963774 Run SysReset() only from retro_run, causes retroarch to freeze...

  • SysReset() crashes when loading with a real bios file if it is not called from retro_run(). This is already known based on an already added workaround from previous commit. This moves SysReset() from retro_load_game() to retro_run(). Can't figure out the "why" this happens though and why it gets fixed this way.
    related post: Refuses to load games when mednafen BIOS are present #227

f422f44 Fix show bios bootlogo core option

@inactive123 inactive123 merged commit 2a8fedf into libretro:master Mar 7, 2019
@gingerbeardman
Copy link

gingerbeardman commented Mar 7, 2019 •
edited
Loading

Stellar work!

this needs verification as to which platforms supports -lm for linking

IIRC this would be required by any platform that does not support floating point maths?

@ghost ghost deleted the core_fixes branch March 8, 2019 00:40
@bslenul bslenul mentioned this pull request Mar 8, 2019
Closed
joolswills pushed a commit to joolswills/pcsx_rearmed that referenced this pull request Dec 12, 2022
@gameblabla
Remove CdlGetlocP hack. (libretro#235)
981752f 
This was added back in 2013 or so in PCSX Rearmed
and according to some tests against Tomb Raider 1 (which
is affected by the GetLocP code),
it works properly without this hack.

So let's just remove it as we are now doing it properly.
(Besides, Duckstation and mednafen don't have this hack)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbeardman @inactive123