Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of PC-88 and Spectravideo Icons #468

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

WizzardSK
Copy link
Contributor

@WizzardSK WizzardSK commented Dec 31, 2023

Rename PC-88 icons to "PC-8001 - PC-8801" because the database and thumbnails has this name in libretro database, so the icons for pc88 will display corrrectly

Also renaming Spectravideo - SV to "Spectravideo - SVI-318 - SVI-328" according to libretro database.

Also added Arduboy and Commodore PET icons from https://github.com/Jaffacakelover/retroarch-assets/tree/monoc-ozo, thank you very much!

@WizzardSK WizzardSK changed the title rename pc88 according to database rename pc-88 and spectravideo icons according to database Dec 31, 2023
@fpscan fpscan requested a review from baxysquare December 31, 2023 20:04
@WizzardSK WizzardSK changed the title rename pc-88 and spectravideo icons according to database rename pc-88 and spectravideo icons according to database, new icons Dec 31, 2023
@WizzardSK
Copy link
Contributor Author

Thanks for reviewing and approving.

@baxysquare baxysquare merged commit 923b711 into libretro:master Jan 2, 2024
@baxysquare
Copy link
Collaborator

Thanks @WizzardSK for this PR. You nailed it on the head, so I went ahead and merged it.

Our primary objective is to match the Libretro RDB listings and achieve an ongoing 1:1 ratio. As you've seen, some of these icons are designed and named in anticipation of RDBs that did not exist. We start with a No-Intro name if there is one, and if there's not, the first contributor does their best to name it. File naming is a hidden difficulty in the art of theme management! :-)

We absolutely prioritize renaming icons to match the RDB whenever it's added or has its file name updated, so if you see any others, please feel free to submit a PR. Also, if there are icons missing from the listings, don't hesitate to request them over on #433.

@RobLoach RobLoach changed the title rename pc-88 and spectravideo icons according to database, new icons Fix naming of PC-88 and Spectravideo Icons May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants