-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDL_ShowFileDialogWithProperties with some more options #11170
Conversation
01c23e6
to
4219164
Compare
4219164
to
083543f
Compare
It seems that the only build issues that remain are platform-specific build files. Are there instructions on how to update/refresh them? If possible, I'd like to learn the steps, so that I don't have to ask someone else to do it for me each time. |
083543f
to
78c099a
Compare
@Semphriss, can you rebase this PR? We'd like to merge it for 3.2.0. Thanks! |
78c099a
to
396e789
Compare
Done! |
It looks like you need to update Android.mk and the Visual Studio projects? |
Indeed; are there instructions on how to do that? I must admit I've never done that for any PR until today... |
Edit Android.mk, add the new file in the sorted list. |
For XCode, is there a specific pattern for the magic numbers to use? |
No, I usually use Xcode to update the project. If you don't have access to it, we can merge as-is, and I can add the file afterwards. |
396e789
to
39d8e2a
Compare
Pushed; I don't have access to XCode for the moment so I'll leave it as-is for now. |
Merged, thanks! |
I've updated the Xcode project as well. |
Description
--attach
option. The only issue is that it supports only X11, so no Wayland support still.While deciding the names of the properties, I noticed that some boolean properties are typed as
SDL_PROP_..._BOOL
and others asSDL_PROP_..._BOOLEAN
(RIP about the ABI freeze). I followed the second format, which seems to be more common.Existing Issue(s)
Closes #11133
I'd like to commend the only platform that supports every dialog option: Haiku (!). A close second is Zenity (!!), which managed to find the way to support everything as well, even modal dialogs, but only partially because it lacks Wayland support so I count it as half a point. Every other platform lacks at least one option completely: macOS and XDG Portals don't allow labeling the cancel button, Windows doesn't (I believe) allow labeling either button, and Android neither buttons nor dialog title, and no folder support at all as well (though those are probably not just relevant to the platform).