Add support for blocking sockets #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I promised a while ago in Issue #113, here's support for blocking sockets modes, as well as setting OS-handled socket send/receive timeouts. This is my first time contributing to an SDL project, so I'm sorry if I do something wrong!
Functions added:
SDLNet_SetSocketBlockingSDLNet_GetSocketBlockingSDLNet_SetBlockingSocketTimeoutAll of these accept arguments of pointers to
SDLNet_GenericSocket, a new union of socket types, which is also now the paramater type forSDLNet_WaitUntilInputAvailablesimple-http-get.cmakes use of blocking sockets now.PS: I haven't fully tested this code on a Unix system, only Windows, so their might be bugs there.