Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reporter and Runner #155

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add Reporter and Runner #155

merged 4 commits into from
Apr 23, 2024

Conversation

james-d-mitchell
Copy link
Member

No description provided.

Joseph-Edwards
Joseph-Edwards reviewed Apr 22, 2024
View reviewed changes
@james-d-mitchell
Copy link
Member Author

I think the CI will fail until libsemigroups/libsemigroups#532 is merged.

Joseph-Edwards
Joseph-Edwards reviewed Apr 22, 2024
View reviewed changes
Joseph-Edwards
Joseph-Edwards reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@Joseph-Edwards Joseph-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the addition of a repr/removal of the TODO, this all looks good to me. I noticed a few other TODOs when I started the review, but I think your subsequent pushes in the meantime have removed them.

@james-d-mitchell
Copy link
Member Author

Other than the addition of a repr/removal of the TODO, this all looks good to me. I noticed a few other TODOs when I started the review, but I think your subsequent pushes in the meantime have removed them.

I forgot to add the doc files, which I've done, now, I'm not sure I'm happy with those, can we perhaps discuss at some point?

@Joseph-Edwards
Copy link
Collaborator

Other than the addition of a repr/removal of the TODO, this all looks good to me. I noticed a few other TODOs when I started the review, but I think your subsequent pushes in the meantime have removed them.

I forgot to add the doc files, which I've done, now, I'm not sure I'm happy with those, can we perhaps discuss at some point?

Ah yeah I missed that. I'm happy to discuss the docs at some point

@james-d-mitchell james-d-mitchell added the v1 Label for issues/prs for v1 label Apr 22, 2024
@james-d-mitchell james-d-mitchell mentioned this pull request Apr 22, 2024
Closed
@james-d-mitchell james-d-mitchell force-pushed the runner-hpp branch 4 times, most recently from 6d0a2ea to 04871c8 Compare April 22, 2024 16:40
This was referenced Apr 23, 2024
Merged
Merged
@Joseph-Edwards Joseph-Edwards merged commit 345d979 into libsemigroups:v1 Apr 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joseph-Edwards Joseph-Edwards Joseph-Edwards left review comments

Assignees
No one assigned
Labels
v1 Label for issues/prs for v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-d-mitchell @Joseph-Edwards