Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kick team member to /api/ #69

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Move kick team member to /api/ #69

merged 1 commit into from
Dec 8, 2023

Conversation

tors42
Copy link
Contributor

@tors42 tors42 commented Dec 8, 2023

Heads up!

lichess-org/lila@9ee36b18
The endpoint has been moved, so next lila deploy, old scripts won't work any longer...

    /team/:id/kick/:user   controllers.Team.kickUser(id, user)

->

/api/team/:id/kick/:user   controllers.TeamApi.kickUser(id, user)

Thoughts about compatibility:

  • I guess one could "ask" lichess to keep the old endpoint around for a bit to give users a chance to adapt...
  • I guess one could make a berserk version which knows both endpoints "if 404, try new endpoint", so it is possible to release berserk even before next lila deploy and any user running latest berserk will never see a problem
  • ... or one could try to keep things simple and let the risk of someone running into a problem happen 😅

lichess-org/lila@9ee36b18

____/team/:id/kick/:user controllers.Team.kickUser(id, user)
/api/team/:id/kick/:user controllers.TeamApi.kickUser(id, user)
@ornicar
Copy link

ornicar commented Dec 8, 2023

It's a very niche endpoint, I think it's ok to break things in this particular case

@kraktus kraktus merged commit 26b7d5b into lichess-org:master Dec 8, 2023
21 checks passed
@tors42 tors42 deleted the move-kick-team-member-endpoint branch December 8, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants