Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options to enable stats in container #266

Merged
merged 1 commit into from
May 12, 2024

Conversation

cyqsimon
Copy link
Contributor

This adds a way to enable stats in containers.

@cyqsimon
Copy link
Contributor Author

Also something worth considering: adding environment variable configuration support within clap, so that we would no longer need the bespoke scripting in docker-entrypoint.sh. For an example, see svenstaro/miniserve#1160.

This would also allow other deployment methods to use environment variable configuration too, for example when using systemd.

@niklasf niklasf merged commit 992d927 into lichess-org:master May 12, 2024
6 checks passed
niklasf added a commit that referenced this pull request May 12, 2024
@niklasf
Copy link
Member

niklasf commented May 12, 2024

Thanks!

@cyqsimon cyqsimon deleted the container-config branch May 13, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants