Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library #66

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Update library #66

merged 10 commits into from
Nov 22, 2023

Conversation

Tsvetov
Copy link
Contributor

@Tsvetov Tsvetov commented Nov 16, 2023

Good evening!
Updated the libraries without upgrading the Python version

@Tsvetov
Copy link
Contributor Author

Tsvetov commented Nov 16, 2023

I upgraded the Python version to 3.9 3.10.

GitHub checks don't work.

@licht1stein
Copy link
Owner

atts API might have changed, do the tests work locally?

@Tsvetov
Copy link
Contributor Author

Tsvetov commented Nov 19, 2023

Yes, on these versions nox is all green :) including tests

@licht1stein
Copy link
Owner

Take a look at the CI files in .github/workflows

@Tsvetov
Copy link
Contributor Author

Tsvetov commented Nov 21, 2023

Good afternoon
I updated all versions in workflow, corrected flake8, but the tests do not work. Although locally they are green (
Can you tell me how to view detailed logs on GitHub?

@licht1stein
Copy link
Owner

On my end it looks like this right on the pull request.

image

The strange thing is that it seems to show the tests have passed, I don't see the reason for failing.

@licht1stein
Copy link
Owner

Found it, just keep tests for 3.10 in nox file and we'll be good to go

image

@licht1stein
Copy link
Owner

You can probably just remove python versions here:

image

@licht1stein
Copy link
Owner

Let nox just run tests in the environment that it's running, and it will adgere to github actions settings

@Tsvetov
Copy link
Contributor Author

Tsvetov commented Nov 22, 2023

Thanks for helping me )

@licht1stein
Copy link
Owner

Of course, that's what open-source is all about

@licht1stein licht1stein merged commit b433094 into licht1stein:master Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants